Skip to content

[WIP] [DO NOT MERGE] Update sdk to use loopback 3.x - #244

Closed
davidcheung wants to merge 3 commits into
masterfrom
3.x
Closed

[WIP] [DO NOT MERGE] Update sdk to use loopback 3.x#244
davidcheung wants to merge 3 commits into
masterfrom
3.x

Conversation

@davidcheung

@davidcheung davidcheung commented Sep 29, 2016

Copy link
Copy Markdown
Contributor

tests are skipped because they broken, sdk ideally should be compatible with both Loopback 2 and 3, therefore please DO NOT MERGE

@davidcheung

Copy link
Copy Markdown
Contributor Author

@slnode test please

Comment thread test.e2e/spec/services.spec.js Outdated
'count',
'prototype$updateAttributes',
'prototype$patchAttributes',
'updateAttributes',

@davidcheung davidcheung Sep 29, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this test case it manually modifies the string so the test case passes....
is it a problem with https://github.com/strongloop/strong-remoting/blob/master/lib/rest-adapter.js has no concept of aliases? which is what sdk-angular interfaces with

not sure what the fix should be,
i see a couple options

  • remap updateAttributes as main method, and use patchAttribute as alias instead
  • prototype method aliases should get named the same way? (not sure about the current behavior need to dig deeper)

@bajtos thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I see both updateOrCreate and upsert in the list above, I think both strong-remoting and this SDK support remote method aliases.

I would expect to see prototype$patchAttributes and prototype$updateAttributes listed for LB 3.0 (and hopefully for 2.x too).

@davidcheung

davidcheung commented Nov 15, 2016

Copy link
Copy Markdown
Contributor Author

closing in favor of #253
and the branch naming is causing ci builds to fail so deleting branch as well (since we will merge lb3 branch to master, and keep loopback-2.x branch as long lived)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants